Skip to content

Support Clock-based sleep APIs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

Support Clock-based sleep APIs #216

merged 2 commits into from
Oct 26, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 24, 2022 •
edited
Loading

This PR adds support for Task.sleep(until:clock:) and other Clock sleep API family.

@github-actions
Copy link

github-actions bot commented Oct 24, 2022 •
edited
Loading

Time Change: +55ms (0%)

Total Time: 17,868ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 21ms +3ms (13%) ⚠️
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 19ms +1ms
Serialization/JavaScript function call from Swift 168ms +2ms (1%)
Serialization/Swift Int to JavaScript with assignment 450ms -4ms (0%)
Serialization/Swift Int to JavaScript with call 1,387ms -5ms (0%)
Serialization/JavaScript Number to Swift Int 465ms +1ms (0%)
Serialization/Swift String to JavaScript with assignment 512ms +1ms (0%)
Serialization/Swift String to JavaScript with call 1,483ms -4ms (0%)
Serialization/JavaScript String to Swift String 5,572ms +84ms (1%)
Object heap/Increment and decrement RC 7,775ms -18ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 2ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 5ms

@kateinoigakukun kateinoigakukun requested a review from a team October 25, 2022 01:27
@kateinoigakukun kateinoigakukun merged commit 99c9965 into main Oct 26, 2022
@kateinoigakukun kateinoigakukun deleted the katei/5.7-clock-sleep branch October 26, 2022 01:28
@kingjay66
Copy link

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonihemi yonihemi yonihemi approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kateinoigakukun @kingjay66 @yonihemi @j-f1